From 2adbf6dc29dd15de88df4109185ad4d88ada2077 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Tue, 23 Jun 2015 18:10:51 +0100 Subject: [PATCH] libxl: spawn: Always debug log middle child process death Otherwise the debug log is strangely devoid of an explanation for the spawn completing. We decorate `what', as otherwise the logged message is rather alarming (especially if the death is due to us sending SIGKILL, which even happens on the success path). Signed-off-by: Ian Jackson Acked-by: Wei Liu --- v4: New patch in this version of the series. --- tools/libxl/libxl_exec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libxl/libxl_exec.c b/tools/libxl/libxl_exec.c index 85cbde05cb..ecb30cfbae 100644 --- a/tools/libxl/libxl_exec.c +++ b/tools/libxl/libxl_exec.c @@ -411,6 +411,8 @@ static void spawn_middle_death(libxl__egc *egc, libxl__ev_child *childw, ((WIFEXITED(status) && WEXITSTATUS(status)==0) || (WIFSIGNALED(status) && WTERMSIG(status)==SIGKILL))) { /* as expected */ + const char *what = GCSPRINTF("%s (dying as expected)", ss->what); + libxl_report_child_exitstatus(CTX, XTL_DEBUG, what, pid, status); } else if (!WIFEXITED(status)) { int loglevel = ss->detaching ? XTL_WARN : XTL_ERROR; const char *what = -- 2.30.2